Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation issues and compatibility with current pyrocko and pyqtgraph #115

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

emolch
Copy link
Member

@emolch emolch commented Dec 5, 2023

Should fix #113.

Tested in a pip env with --system-site-packages on Ubuntu 22.04 and system installed pyqtgraph, qt5, etc.

Isolated pip env install is still broken because of incompatibility with newer pyqtpgraph. Simple downgrading of pyqtgraph did not help because of incompatibilities between pyqtpgraph/qt5/numpy.

@emolch
Copy link
Member Author

emolch commented Dec 5, 2023

Now includes some patches to get it working in newer pyqtgraph.

@emolch emolch changed the title Fix installation issues and compatibility with current pyrocko Fix installation issues and compatibility with current pyrocko and pyqtgraph Dec 5, 2023
@miili
Copy link
Member

miili commented Dec 9, 2023

Thanks for the PR. I believe moving to something like https://github.com/pdm-project/pdm can help with cleaner dependencies. I will have a look next week.

@hvasbath
Copy link
Member

I confirm that with this branch the error does not occur anymore! Tested on python3.8 and 3.11. ubuntu 20.04

@hvasbath
Copy link
Member

hvasbath commented Dec 10, 2023

When testing stumbled upon another issue when loading the scene. with spool. Pyqtgraph version 0.11 and 0.12 have an issue which is fixed in 0.13. See here: #114 So maybe we should fix the version in the requriements to >=0.13? So in order to support younger pyqtgraphs we would need to write a wrapper around the show_grid method to fix their int/float conversion issues calling the function ...

@hvasbath
Copy link
Member

Another issue: #117

@hvasbath
Copy link
Member

Ok I didnt stumble on another issue using:
Ubuntu 20.04, python3.8, pyqtgraph 0.13.3

@emolch
Copy link
Member Author

emolch commented Dec 10, 2023

When testing stumbled upon another issue when loading the scene. with spool. Pyqtgraph version 0.11 and 0.12 have an issue which is fixed in 0.13. See here: #114 So maybe we should fix the version in the requriements to >=0.13? So in order to support younger pyqtgraphs we would need to write a wrapper around the show_grid method to fix their int/float conversion issues calling the function ...

Ubuntu 22.04 ships with pyqtgraph 0.12, so please don't set the requirements to >=0.13, it would break system native installs. Because also the qt5 version is older there, there is no problem with that combination. If there is any, we can certainly add a small fix.

@miili
Copy link
Member

miili commented Jan 18, 2024

lgtm

@miili miili merged commit 1402f3c into master Jan 18, 2024
5 checks passed
@miili miili deleted the bugfix/compatibility branch January 18, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

circular import issue
3 participants