Fix Cython.Build module import #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module name starts with an uppercase "C" or else it won't be found (on case-sensitive file systems). Also, rebuilt the C files with Cython 0.9.26 to fix any issues that were present for builds against Python 3.10 or when using newer versions of gcc. Fixes: pyranges#45, pyranges#46
kcleal
previously approved these changes
Feb 8, 2022
|
Looking at it now. Thanks. Will need to test locally. Dunno' if I've ever seen uppercase imports before. |
|
Looks good. Would you mind updating the ncls/version.py and CHANGELOG too? |
|
Sorry for the late merge. Will upload to pypi now :D |
|
Should be out now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module name starts with an uppercase "C" or else it won't be
found (on case-sensitive file systems).
Also, rebuilt the C files with Cython 0.9.26 to fix any issues that
were present for builds against Python 3.10 or when using newer
versions of gcc.
Fixes: #45, #46