Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating point intervals? #28

Closed
wmayner opened this issue Feb 12, 2020 · 2 comments
Closed

Floating point intervals? #28

wmayner opened this issue Feb 12, 2020 · 2 comments

Comments

@wmayner
Copy link

wmayner commented Feb 12, 2020

Perhaps this is out of scope given the intended application in genomics, but it would be wonderful if this library worked with floating-point ranges as well.

@endrebak
Copy link
Collaborator

Yes, agreed. There is no reason it cannot be done afaicr, float equality will lead to hiccups, but it likely does not matter.

It is not going to be something I do very soon, only have six months of my PhD. But if enough people tell me here that they desire this functionality and why, I might be persuaded :)

I would accept and help out on prs :)

endrebak added a commit that referenced this issue Feb 24, 2020
@endrebak
Copy link
Collaborator

Try the FNCLS in 0.0.53. See here: https://github.com/biocore-ntnu/ncls/blob/master/examples/test_fncls.py

Would love to hear how you use it and please remember to cite our paper :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants