Skip to content

Commit

Permalink
Ig248 fix header (#31)
Browse files Browse the repository at this point in the history
* Add missing functions in header file.

Before this change, calling `python -c "import ncls"` after build caused error `.../ncls.cpython-37m-x86_64-linux-gnu.so: undefined symbol: find_suboverlap_start`

* Update changelog and pxd

* Bump version

Co-authored-by: Igor Gotlibovych <igor.gotlibovych@gmail.com>
  • Loading branch information
endrebak and ig248 authored Feb 20, 2020
1 parent 6cca249 commit 2324da8
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 0.0.52 (20.02.20)
- fix missing functions in headers (thanks Igor Gotlibovych)

# 0.0.51 (03.12.19)
- make setup.py installable distutils if cython isn't installed

Expand Down
2 changes: 1 addition & 1 deletion ncls/src/cncls.pxd
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ cdef extern from "ncls/src/intervaldb.h":
int len

int find_overlap_start(int64_t start, int64_t end, IntervalMap im[], int n)
int find_suboverlap_start(int64_t start, int64_t end, int isub, IntervalMap im[], SublistHeader subheader[])
int imstart_qsort_cmp(void *void_a,void *void_b)
# int target_qsort_cmp(void *void_a,void *void_b)
IntervalMap *read_intervals(int n,FILE *ifile)
SublistHeader *build_nested_list(IntervalMap im[],int n,int *p_n,int *p_nlists)
SublistHeader *build_nested_list_inplace(IntervalMap im[],int n,int *p_n,int *p_nlists)
Expand Down
1 change: 1 addition & 0 deletions ncls/src/cncls32.pxd
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ cdef extern from "ncls/src/intervaldb32.h":
int len

int find_overlap_start(int32_t start, int32_t end, IntervalMap im[], int n)
int find_suboverlap_start(int32_t start, int32_t end, int isub, IntervalMap im[], SublistHeader subheader[])
int imstart_qsort_cmp(void *void_a,void *void_b)
# int target_qsort_cmp(void *void_a,void *void_b)
SublistHeader *build_nested_list(IntervalMap im[],int n,int *p_n,int *p_nlists)
Expand Down
1 change: 1 addition & 0 deletions ncls/src/intervaldb.h
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ typedef struct {
extern int *alloc_array(int n);

extern int64_t find_overlap_start(int64_t start,int64_t end,IntervalMap im[],int n);
extern int find_suboverlap_start(int start,int end,int isub,IntervalMap im[],SublistHeader subheader[]);
extern int imstart_qsort_cmp(const void *void_a,const void *void_b);
extern int target_qsort_cmp(const void *void_a,const void *void_b);
extern IntervalMap *read_intervals(int n,FILE *ifile);
Expand Down
1 change: 1 addition & 0 deletions ncls/src/intervaldb32.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ typedef struct IntervalIterator_S {
extern int *alloc_array(int n);

extern int find_overlap_start(int start,int end,IntervalMap im[],int n);
extern int find_suboverlap_start(int start,int end,int isub,IntervalMap im[],SublistHeader subheader[]);
extern int imstart_qsort_cmp(const void *void_a,const void *void_b);
extern int target_qsort_cmp(const void *void_a,const void *void_b);
extern SublistHeader *build_nested_list(IntervalMap im[],int n,
Expand Down
2 changes: 1 addition & 1 deletion ncls/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.0.51"
__version__ = "0.0.52"

0 comments on commit 2324da8

Please sign in to comment.