Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy-minimal for windows #1301

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented Jan 16, 2025

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f davide-f mentioned this pull request Jan 16, 2025
8 tasks
@davide-f
Copy link
Member Author

FYI @Eric-Nitschke

@Eric-Nitschke
Copy link
Contributor

Hey @davide-f, thank you for tackeling this issue!
I can confirm that the code is now working properly on my machine (Windows 11) and doesn't produce the error described in issue #1299 anymore.

@davide-f davide-f merged commit 5d3e89a into pypsa-meets-earth:main Jan 16, 2025
4 checks passed
@davide-f
Copy link
Member Author

Many thanks for the double check :) merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants