Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for transport data url not working #362

Merged

Conversation

GbotemiB
Copy link
Contributor

@GbotemiB GbotemiB commented Jul 30, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

The PR creates a fix for url not available in the prepare_transport_data_input.py script

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

Copy link
Collaborator

@hazemakhalek hazemakhalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed and agreed. In case of download failure, we use an already constructed csv file.
The download has been crashing for a week now, so carry out this solution because we see this as a recurring/consistent issue.

The raw file is not initially saved in the workflow, so we proceed with the combined csv and skip several steps in the script since no one of us has the raw file. To be adapted to the raw file once the download works again.

@hazemakhalek hazemakhalek merged commit d178a15 into pypsa-meets-earth:main Jul 31, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants