Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix incorrect recognition of the ISO-2 country code "NA" as NaN … #273

Conversation

doneachh
Copy link
Collaborator

…value

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@doneachh
Copy link
Collaborator Author

@energyLS i copied the function read_csv_nafix from pypsa-earth _helpers to pypsa-earth sec helpers.
Otherwise i would have update the systempaths for the both scripts and i didnt know whats the more ugly / fancy development strategy.

Alternative:

import sys
sys.path.append('./pypsa-earth/scripts')

in both scripts for the whole script

@doneachh doneachh self-assigned this Feb 1, 2024
Copy link
Collaborator

@energyLS energyLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@energyLS energyLS merged commit 540eff0 into main Feb 1, 2024
5 checks passed
@davide-f davide-f deleted the 266-various-errors-related-to-incorrect-recognition-of-the-iso-2-country-code-na-as-nan-value branch March 15, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various errors related to incorrect recognition of the ISO-2 country code "NA" as NaN value
2 participants