Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the airports workflow #231

Merged
merged 7 commits into from
Sep 1, 2023
Merged

add the airports workflow #231

merged 7 commits into from
Sep 1, 2023

Conversation

hazemakhalek
Copy link
Collaborator

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@hazemakhalek hazemakhalek requested a review from Eddy-JV August 31, 2023 21:08
@Eddy-JV
Copy link
Collaborator

Eddy-JV commented Sep 1, 2023

I have the following comments:

  1. Why did you comment out: keeping only large and medium airport (see below)?
    # Keep only airports that are of type medium and large
    # df = df.loc[df["type"].isin(["large_airport", "medium_airport"])]

Originally, the code keeps only medium and large airports and make the weighting like this (Please note that the last line must be equal to 2 and not 3:

    # Keep only airports that are of type medium and large
    df = df.loc[df["type"].isin(["large_airport", "medium_airport"])]

    df.insert(2, "airport_size_nr", 1)
    df.loc[df["type"].isin(["medium_airport"]), "airport_size_nr"] = 1
    df.loc[df["type"].isin(["large_airport"]), "airport_size_nr"] = 2
  1. If you did this on purpose, then we have to adapt the following snippet in the script because we have to deal with these types of airports for the weighting and remove the colsed ones: ['small_airport', 'heliport', 'seaplane_base', 'medium_airport', 'large_airport', 'closed'].
    df.insert(2, "airport_size_nr", 1)
    df.loc[df["type"].isin(["medium_airport"]), "airport_size_nr"] = 1
    df.loc[df["type"].isin(["large_airport"]), "airport_size_nr"] = 3

I suggest, that we keep only medium and large airports, as we originally did.

@hazemakhalek
Copy link
Collaborator Author

3. pt the following snippet in the script because we have to deal with these types of airports for the weighting and remove the colsed ones: ['small_airport', 'heliport', 'seaplane_base', 'medium_airport', 'large_airport', 'closed'].

I did not intend to keep the small one, that was commented out by mistake. I changed the sizing factor however to 3. Judging by a few checks in 3 countries, the large airports are usually much larger than the medium ones. I can set that as a config parameter to change accordingly

@Eddy-JV Eddy-JV merged commit 99ac2ea into main Sep 1, 2023
@Eddy-JV Eddy-JV deleted the airports_workflow branch September 1, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants