Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emission bugs #215

Merged
merged 7 commits into from
Aug 23, 2023
Merged

Fix emission bugs #215

merged 7 commits into from
Aug 23, 2023

Conversation

hazemakhalek
Copy link
Collaborator

Changes proposed in this Pull Request

This PR fixes a few bugs that occurred in counting the emissions. Main sectors affected are "industry" (oil and coal) as well as the custom sectors "services" and "residential"

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@hazemakhalek hazemakhalek marked this pull request as ready for review August 10, 2023 14:09
@hazemakhalek hazemakhalek requested a review from energyLS August 10, 2023 14:09
Copy link
Collaborator

@energyLS energyLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you have kicked out co2 emissions from biogas/biomass. I think it makes sense if we don't account for negative emissions when introducing biogas/biomass in spatial.biomass.nodes, which I am not quite sure about

scripts/prepare_sector_network.py Show resolved Hide resolved
scripts/prepare_sector_network.py Show resolved Hide resolved
scripts/prepare_sector_network.py Show resolved Hide resolved
scripts/prepare_sector_network.py Show resolved Hide resolved
Copy link
Collaborator

@energyLS energyLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All issues resolved

@energyLS energyLS merged commit 9f843b9 into main Aug 23, 2023
@davide-f davide-f deleted the fix_emission_bugs branch February 5, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants