Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptation to 2-digit GADM id, matrix alignment, mock_snakemake directory #193

Merged
merged 3 commits into from
May 8, 2023

Conversation

cpschau
Copy link
Collaborator

@cpschau cpschau commented Apr 5, 2023

Changes proposed in this Pull Request

  • Alignment of prepare_sector network with 2-digit-id which is originally received in busmap of alternatively clustered network
  • Prevention of dropping column which is necessary for industry demand calculation performed in line 86.
  • Directory change for successful mock_snakemake execution when debugging plot_network and plot_summary scripts
  • Removal of leading whitespace, which enables assignment of tech colors for balance summary plots

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@energyLS
Copy link
Collaborator

@cschau-ieg is this ready for review? If so, please convert the PR from draft to ready

@cpschau cpschau marked this pull request as ready for review April 26, 2023 17:57
@cpschau
Copy link
Collaborator Author

cpschau commented Apr 26, 2023

@cschau-ieg is this ready for review? If so, please convert the PR from draft to ready

I just marked it as ready. The PR was depending on #670 in pypsa-earth, which is merged by now.

Copy link
Collaborator

@energyLS energyLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, changes were checked and the issue is fixed

@energyLS energyLS merged commit f727188 into pypsa-meets-earth:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants