Generic events #8324
Merged
Generic events #8324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
commented
Jul 26, 2020
68ada76 to
2ce0164
Compare
|
I'm going to validate the migration locally, but have no issues with this. I will ask to coordinate merge so I can be on hand though. |
dstufft
reviewed
Apr 19, 2022
dstufft
approved these changes
Apr 19, 2022
dstufft
reviewed
Apr 19, 2022
|
👍 |
|
@ewdurbin I'll let you merge whenever you're free to babysit this. |
|
🖖🏼 20.778 month old PR 🚢 |
This was referenced Apr 23, 2022
domdfcoding
pushed a commit
to domdfcoding/warehouse
that referenced
this pull request
Jun 7, 2022
* Generic events * Update migration to rename table/columns in place * Use AbstractConcreteBase * Address feedback from review * Remove commented out line * Linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a generic
HasEventssubclass for models that have related events, and migrates the existingUserEventsandProjectEventsmodels to it. It uses generic associations but maintains essentially the same underlying "table per related" structure.This ensures that events are created and associated with their sources in a consistent and generic way, and allows us to add event support to any new or existing model simply by adding the
HasEventsmixin to the models class definition.