Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move 2FA and API tokens out of beta #7250

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Move 2FA and API tokens out of beta #7250

merged 1 commit into from
Jan 17, 2020

Conversation

brainwane
Copy link
Contributor

Addresses #5661.

@brainwane brainwane requested review from ewdurbin, nlhkabu and di January 16, 2020 23:59
@brainwane
Copy link
Contributor Author

@yeraydiazdiaz could you give this a look?

yeraydiazdiaz
yeraydiazdiaz approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@yeraydiazdiaz yeraydiazdiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brainwane brainwane added this to the Beta blockers milestone Jan 17, 2020
@brainwane brainwane merged commit 53ab9e3 into pypi:master Jan 17, 2020
@brainwane brainwane deleted the end-webauthn-and-tokens-beta branch January 17, 2020 10:08
@brainwane
Copy link
Contributor Author

Thanks @yeraydiazdiaz .

@ewdurbin ewdurbin mentioned this pull request Jan 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeraydiazdiaz yeraydiazdiaz yeraydiazdiaz approved these changes

@ewdurbin ewdurbin Awaiting requested review from ewdurbin

@nlhkabu nlhkabu Awaiting requested review from nlhkabu

@di di Awaiting requested review from di

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Beta blockers
Development

Successfully merging this pull request may close these issues.
2 participants
@brainwane @yeraydiazdiaz