-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warehouse: Allow maintainers to craft project tokens #6301
warehouse: Allow maintainers to craft project tokens #6301
Conversation
0a71cce
to
f118b5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The token management screen links to manage/project/[project name]/releases/
(the link provided in the "scope" item for a project-scoped token) but, as a maintainer, that gives me an Access Denied: "You don't have permission to view this page" error. Perhaps it should link to project/[project name]/
if the user is a maintainer. Or if that's inelegant, it should link to that page for all users.
This avoids 403s for tokens created by maintainers.
Done: I've linked to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on localhost and I can successfully -- as a project maintainer -- create a token and upload a distribution with it.
Use the user.projects relation.
Accidentally removed in pypi#6288.
@di should be good for another pass! |
Closes #6262.
cc @di / @dstufft / @brainwane