Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force user to explicitly select token scope, show warning if user scopes to account #6274

Merged
merged 7 commits into from
Jul 29, 2019
Merged

Force user to explicitly select token scope, show warning if user scopes to account #6274

merged 7 commits into from
Jul 29, 2019

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Jul 26, 2019 •
edited by nlhkabu
Loading

Closes #6266
Builds on #6271.

cc @nlhkabu

@woodruffw woodruffw mentioned this pull request Jul 26, 2019
Closed
@nlhkabu nlhkabu requested a review from di July 27, 2019 09:56
@nlhkabu
Copy link
Contributor

nlhkabu commented Jul 27, 2019

Updated errors (to be consistent)

Screenshot from 2019-07-27 10-43-56

Updated warning text

Only shown when "whole account" is selected:
Screenshot from 2019-07-27 10-44-24

@nlhkabu nlhkabu requested a review from ewdurbin July 27, 2019 09:59
@nlhkabu
Copy link
Contributor

nlhkabu commented Jul 27, 2019

ready for review @di or @ewdurbin:

Functional updates:

  • Force users to explicitly select scope (and show form error if no scope selected)
  • Show "warning" message if "entire account" scope is selected

@nlhkabu nlhkabu mentioned this pull request Jul 27, 2019
Closed
@nlhkabu nlhkabu changed the title Show warning when user scopes API key to account Force user to explicitly select token scope, show warning if user scopes to account Jul 27, 2019
@nlhkabu nlhkabu force-pushed the tob-warn-users-for-whole-account-api-keys branch from 4468e55 to 29d199e Compare July 27, 2019 10:12
@di di merged commit 8d11fb4 into pypi:master Jul 29, 2019
@woodruffw woodruffw deleted the tob-warn-users-for-whole-account-api-keys branch July 29, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@di di di left review comments

@ewdurbin ewdurbin Awaiting requested review from ewdurbin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API token default scope: user or project?
3 participants
@woodruffw @nlhkabu @di