Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webauthn beta badge #5977

Closed
wants to merge 55 commits into from
Closed

Add webauthn beta badge #5977

wants to merge 55 commits into from

Conversation

nlhkabu
Copy link
Contributor

@nlhkabu nlhkabu commented Jun 8, 2019

Closes #5976

To be merged after #5795. I have made this as a separate PR, so that we can easily revert to remove the badges :)

Screenshots

Screenshot from 2019-06-08 11-12-06
Screenshot from 2019-06-08 11-14-43
Screenshot from 2019-06-08 11-12-49
Screenshot from 2019-06-08 11-12-42

@brainwane as per your issue, did you want me to link through to here, or are we planning to add a FAQ?

woodruffw added 30 commits June 4, 2019 10:26
Adds requisite view behavior, client-side handling,
templates, interfaces, and services.

Still incomplete.
Adds the client-side JS needed for login, some of the
form validation, some of the views, some of the services.
Set cookie properly on WebAuthn login.
Add WIP account form tests.
@nlhkabu nlhkabu added the blocked Issues we can't or shouldn't get to yet label Jun 8, 2019
@brainwane
Copy link
Contributor

@brainwane as per your issue, did you want me to link through to here, or are we planning to add a FAQ?

@nlhkabu Good question. I think we should add a "what are beta features?" FAQ item. And then we can update that FAQ with "here are the current beta features" and provide appropriate hyperlinks -- in the case of WebAuthn I need to update https://wiki.python.org/psf/WarehousePackageMaintainerTesting to give context and suggest how to test it.

@brainwane
Copy link
Contributor

@nlhkabu

Here's a quick draft of an FAQ item:

Q: What does the "beta" badge mean? What are Warehouse's current beta features?

A. While Warehouse's maintainers are deploying new features, at first we mark them with a small "beta" symbol to tell you: this should probably work fine, but it's new and less tested than other site functionality. Right now our beta features are:

I updated https://wiki.python.org/psf/WarehousePackageMaintainerTesting enough that it would be fine to link to in an FAQ.

@nlhkabu nlhkabu mentioned this pull request Jun 12, 2019
@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jun 13, 2019

Updated to work with new UI and FAQ:

Screenshot from 2019-06-13 07-14-44

Screenshot from 2019-06-13 07-13-51

@ewdurbin
Copy link
Member

replaced with #6027, the merge situation got a bit too wild for me to unwind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issues we can't or shouldn't get to yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"beta" badge for WebAuthn beta feature within Account Settings
5 participants