Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error reporting for token permissions #6232

Closed
woodruffw opened this issue Jul 23, 2019 · 2 comments · Fixed by #6353
Closed

Improved error reporting for token permissions #6232

woodruffw opened this issue Jul 23, 2019 · 2 comments · Fixed by #6353
Labels
feature request
Milestone
Beta blockers

Comments

@woodruffw
Copy link
Member

As a follow on to #6084, we should improve the message returned to users when their provided token isn't acceptable in the given context (e.g., if it doesn't match the package or doesn't have the right permissions at all).

Current master provides this message, which is misleading:

The user 'brainwane' isn't allowed to upload to project 'Forms990-analysis'

#6084 changes that message to the more generic:

The credential associated with user 'brainwane' isn't allowed to upload to project 'Forms990-analysis'

But ideally we'd have something like this:

This API token is not valid for project 'Forms990-analysis'

cc @nlhkabu @brainwane
@woodruffw woodruffw mentioned this issue Jul 23, 2019
Merged
2 tasks
@brainwane brainwane added this to the OTF Security work milestone Aug 2, 2019
ewdurbin added a commit that referenced this issue Aug 2, 2019
@ewdurbin
Approach for resolving #6232
dc22410 
Will need review from @dstufft and @woodruffw

If they approve... needs tests/etc
@brainwane
Copy link
Contributor

@ewdurbin is working on a fix in #6353.

@brainwane brainwane mentioned this issue Aug 8, 2019
Closed
@brainwane brainwane removed this from the OTF Security work milestone Sep 8, 2019
@brainwane
Copy link
Contributor

Contractors on the OTF-funded work need to stop work on the security features in order to ensure we complete the accessibility and internationalization work by the end of the month. Therefore, while this is necessary to get us out of beta for this feature #5661 (comment) , I'm removing it from the milestone.

@brainwane brainwane added this to the Beta blockers milestone Sep 8, 2019
@ewdurbin ewdurbin mentioned this issue Sep 9, 2019
Merged
ewdurbin added a commit that referenced this issue Jan 16, 2020
@ewdurbin
Approach for resolving #6232
2bb7935 
Will need review from @dstufft and @woodruffw

If they approve... needs tests/etc
@brainwane brainwane mentioned this issue Jan 16, 2020
Closed
ewdurbin added a commit that referenced this issue Jan 16, 2020
@ewdurbin
Approach for resolving #6232
57a76fa 
Will need review from @dstufft and @woodruffw

If they approve... needs tests/etc
ewdurbin added a commit that referenced this issue Jan 16, 2020
@ewdurbin
Approach for resolving #6232 (#6353)
72db1a6 
* Approach for resolving #6232

Will need review from @dstufft and @woodruffw

If they approve... needs tests/etc

* updates based on feedback from @dstufft

still unsure about the approach

* fix tests/cleanup

* add missing reason, standarize to f-strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
Beta blockers
Development

Successfully merging a pull request may close this issue.

Approach for resolving #6232 pypi/warehouse
3 participants
@di @brainwane @woodruffw