-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create test suite #28
Conversation
The current tests intentionally expose errors due to #7 . IMO the usefulness of this package is quite limited unless it is complete. |
These packages are not needed to run tests, and they polute the testbed.
870b9ee
to
da15727
Compare
I'm happy to expand ffc46e2 (Update lists) into multiple commits with more descriptive commit messages, but I'm going to focus on getting more tests written to expose the other missing module sets in a reliable manner. I've avoided updating py26, py32 & py33 except the blindly obvious, as they should be either discarded or CI added to run the tests on them, if they are going to be supported. Bad data is often worse than no data. |
@jayvdb thanks for this PR! It would be nice if we had an automated way to capture these missing modules. |
The next set of tests almost provide that, at least for large subsets of the lists. |
@jayvdb this looks good to me. Do you mind running |
ok |
453519e
to
cf4d338
Compare
The remaining sets of modules still not validated that I know of are
Im not familiar with TK modules, but that should be easy to investigate and fix. No 1 is easy, and I am doing that now. I think the other three are best found by running the CPython test suite with an import tracer. No 2 is probably small enough, and stable enough, that manual compilation is feasible by reading the CPython git history. |
@ocefpaf, I think this is about where this PR should end. As you reviewed it half way, I havent done your style requests yet, so you can easily see the latter additions. |
@ocefpaf, probably best to get a review now, fix any critical issues, and get it merged asap, and iterate further after that when the repo is green. |
Hello? |
No description provided.