-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for Flake8. #476
Conversation
The main differences from the defaults are enabling the opinionated bugbear codes and excluding the vendored sources.
Flake8 was meant to be run through |
Codecov ReportBase: 69.16% // Head: 69.16% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## publicapi #476 +/- ##
==========================================
Coverage 69.16% 69.16%
==========================================
Files 11 11
Lines 989 989
==========================================
Hits 684 684
Misses 305 305 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I sometimes run it manually and it flags the vendored files when I do. |
So, don't? Running |
What makes this even more important is that, once I can, I will switch from the official flake8 to |
I mean things like the |
Aside from the vendor exclusion, what's the rationale for these specific settings? |
Git checks out files with CLRF on Windows, so I can't install the pre commit hooks unless I branch off of #474. |
|
This is now closable, as Ruff is used instead of flake8. |
The main differences from the defaults are enabling the opinionated bugbear codes and excluding the vendored sources.