support install into non-ASCII directories #912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b3f876 to
9dfcb43
Compare
gaborbernat
requested changes
Dec 16, 2018
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Python 2 sys.prefix is already not unicode and should not be encoded.
So far only tested on Linux with sys.getfilesystemencoding() == 'utf-8' (certainly it is ascii sometimes, even on the same system, depending on how I've logged in).
This was automatically migrated from #630 to reparent it to the
masterbranch. Please see original pull request for any previous discussion.Original Submitter: @dholth