Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read and write racing on multiple processes. #1941

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Fix read and write racing on multiple processes. #1941

merged 1 commit into from
Sep 18, 2020

Conversation

frostming
Copy link
Contributor

@frostming frostming commented Sep 14, 2020

Thanks for contributing, make sure you address all the checklists (for details on how see

development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

This PR address an issue that read/write on the update log can cause competition on multiple processes.
Close #1938

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #1941 into master will decrease coverage by 0.09%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1941      +/-   ##
==========================================
- Coverage   93.98%   93.89%   -0.10%     
==========================================
  Files          86       86              
  Lines        4225     4228       +3     
==========================================
- Hits         3971     3970       -1     
- Misses        254      258       +4     
Flag Coverage Δ
#tests 93.89% <20.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/virtualenv/app_data/via_disk_folder.py 82.30% <0.00%> (-2.25%) ⬇️
src/virtualenv/util/path/_sync.py 93.10% <100.00%> (ø)
src/virtualenv/seed/embed/base_embed.py 96.22% <0.00%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c0498...a20a4b8. Read the comment docs.

Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect some type of test here too 🤔

@frostming frostming changed the title Change to atomic writing Fix read and write racing on multiple processes. Sep 15, 2020
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit aed87ac into pypa:master Sep 18, 2020
@frostming frostming deleted the atomic-write branch October 30, 2020 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple processes competition on read/write update log
2 participants