Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platformdirs 3.0 compatibility #2499

Closed
cdce8p opened this issue Feb 6, 2023 · 8 comments · Fixed by #2502
Closed

platformdirs 3.0 compatibility #2499

cdce8p opened this issue Feb 6, 2023 · 8 comments · Fixed by #2502

Comments

@cdce8p
Copy link

cdce8p commented Feb 6, 2023

What's the problem this feature will solve?
platformdirs version 3.0 was released a few hours ago. At the moment virtualenv pins <3. Is that necessary or would ´v3´ be compatible? Form the changelog, it looks like a change only to the default config dir on macOS.

"platformdirs<3,>=2.4",

https://github.com/platformdirs/platformdirs/blob/main/CHANGES.rst#platformdirs-300-2023-02-06

@gaborbernat
Copy link
Contributor

Can unpin. PR welcome.

@cdce8p
Copy link
Author

cdce8p commented Feb 7, 2023

Opened #2501

@kendra-human
Copy link

Thanks, @cdce8p it took me a few hours to debug this (via a transitive dep). Kudos for raising the PR.

@johnthagen
Copy link

Just as reference, this will currently screw up Poetry's dependency resolution and push virtualenv back to an old version (which then can break things with old setup.py install behavior):

@gaborbernat
Copy link
Contributor

Ah, poetry! Causing so many problems 😆 I personally don't understand why people use it 😆 will be fixed soon though.

@johnthagen
Copy link

I personally don't understand why people use it

😆 I love it, but definitely understand that it resolves dependencies differently than pip.

Can only dream one day packaging tools will all be unified/standardized.

@gaborbernat
Copy link
Contributor

The only officially supported resolver is what pip uses. So using anything else leads to situations like this; if anything creates more discord, then help unity. So if you're hoping for unified ways, this is your chance to convince poetry not to roll their own standards and logic.

gaborbernat added a commit that referenced this issue Feb 7, 2023
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Resolves #2499
@johnthagen
Copy link

Can confirm that virtualenv 20.19.0 solved this issue.

Thanks!

joelvaneenwyk pushed a commit to joelvaneenwyk/virtualenv that referenced this issue Feb 12, 2023
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Resolves pypa#2499
tarpas pushed a commit to tarpas/virtualenv that referenced this issue Jun 8, 2023
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Resolves pypa#2499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants