-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix keyring support #408
Fix keyring support #408
Conversation
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
==========================================
+ Coverage 77.99% 78.08% +0.09%
==========================================
Files 14 14
Lines 727 730 +3
Branches 104 104
==========================================
+ Hits 567 570 +3
Misses 128 128
Partials 32 32
Continue to review full report at Codecov.
|
Thank you @di and @theacodes - a release with this fix would be appreciated - is there anything I can do to help with that? |
This issue bit me today. I don't often release locally, but when I do, I do rely on keyring. I'll see if I can cut a release. |
I've updated the changelog and version, following patterns from prior commits, and tagged that commit. Unfortunately, I don't have access to upload to PyPI. Would @dstufft or @brainwane or @sigmavirus24 be willing to cut a release? Alternatively, add me to PyPI maintainers if you'd like me to upload the release. |
@jaraco I'd also ask that you not push changes to this project like you've done. PRs are the project's preferred way of working. You pushed release notes that were premature |
@sigmavirus24 My mistake. I was working from the assumption that I had access to help cut releases, so I was seeking to do just that. Since nothing had changed between the last release and this bugfix, it seemed like a low risk bugfix release and I was seeking to get it out. I'll back out the changelog and delete the tag. I was affected by this bug again today. It would be nice to get a fix out. |
Revert "Update changelog and bump version. Ref #408."
Per this comment, fix a regression from #395 that would never successfully import
keyring
. A full explanation as to why this needed changed is in 3ae98ed.Thanks to @adamtheturtle for catching it.