Skip to content

Commit

Permalink
Update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
bhrutledge committed Oct 31, 2019
1 parent e5254b9 commit 04cdc41
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion twine/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ def get_username_from_keyring(system: str) -> Optional[str]:
return None

try:
# Workaround mypy error `module has no attribute "get_credential"`
# TODO: Could this just be keyring.get_credential?
# Would need to update monkeypatch in tests
getter = sys.modules['keyring'].get_credential # type: ignore
Expand Down Expand Up @@ -252,6 +253,7 @@ def get_password_from_keyring(system: str, username: str) -> Optional[str]:

try:
return (
# Workaround mypy error `module has no attribute "get_password"`
sys.modules['keyring'] # type: ignore
.get_password(system, username)
)
Expand Down Expand Up @@ -339,7 +341,8 @@ def get_password(
)


# TODO: Can this be replaced with Python 3 keyword-only arguments?
# TODO: Replace this with Python 3 keyword-only arguments
# See https://github.com/pypa/twine/issues/520
def no_positional(allow_self: bool = False) -> Callable:
"""A decorator that doesn't allow for positional arguments.
Expand Down

0 comments on commit 04cdc41

Please sign in to comment.