Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit warning for explicitly included data files #4789

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Jan 4, 2025

Summary of changes

From what I can tell based on the discussion in #3340, it would make sense to hide the Package would be ignored warning for explicitly including data files (via tool.setuptools.package-data or similar).

@cdce8p cdce8p force-pushed the data-files-warning branch from 00f7524 to 4e8cadd Compare January 4, 2025 12:51
@abravalheri
Copy link
Contributor

abravalheri commented Jan 8, 2025

I have a different understanding of the previous discussion: if the package is not included, then the data files contained by it cannot be included (adding the package itself is a pre-requisite for adding its data files)...

So the warning is a call to action for the users to add the package name in the package list (this would be along the lines of "explicit is better than implicit" and raising awareness of the users that for Python purposes the directories are packages during runtime and can even be imported).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants