Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local schemas to define validation for pyproject.toml #4364

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

abravalheri
Copy link
Contributor

@abravalheri abravalheri commented May 17, 2024

Summary of changes

This facilitates adding/removing options without having to release a whole new version of validate-pyproject.

In general it should help to improve the developer experience when dealing with pyproject.toml validations.

Closes

Pull Request Checklist

tox.ini Outdated Show resolved Hide resolved
@abravalheri abravalheri changed the title Use local schemas to define validation in pyproject.toml Use local schemas to define validation for pyproject.toml May 17, 2024
@abravalheri abravalheri force-pushed the local-schemas branch 2 times, most recently from e22e99c to eacab52 Compare May 22, 2024 09:43
@abravalheri abravalheri marked this pull request as ready for review May 22, 2024 09:51
@abravalheri
Copy link
Contributor Author

@jaraco this is my preferred approach for dealing with the validations, the reason is that it allows contributors and maintainers of setuptools to modify the validations of pyproject.toml locally.

It also helps to clarify the relationships between validate-pyproject and setuptools: validate-pyproject "compiles" the JSON schemas that should be given by setuptools. This way "setuptools" is in charge and does not have to wait for changes in validate-pyproject to perform trivial validation changes.

Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abravalheri abravalheri merged commit 2a46d2d into pypa:main Aug 8, 2024
21 checks passed
@abravalheri abravalheri deleted the local-schemas branch August 8, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants