Warn about deprecation of behaviour that considers modules/packages as "data" when include_package_data=True
#3308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the transition, `build_py` should warn when a module or package is included in the distribution as if it was "package data".
include_package_data=Trueinclude_package_data=True
Previously, the checks would result in a warning per module additionally to the parent package. Now only one warning per parent package is issued.
Closed
2 tasks
2 tasks
jacklovell
added a commit
to cherab/core
that referenced
this pull request
Feb 24, 2023
…ually This allows finer control over what gets packaged, and fixes a deprecation warning in recent setuptools versions (see pypa/setuptools#3308 for detais). It also prevents Cython-transpiled C source files being included in the wheel distribution, which roughly halves the size of the installed distribution.
tmzullinger
added a commit
to tmzullinger/rpmlint
that referenced
this pull request
Mar 6, 2023
Since setuptools-62.3.0¹, a warning is issued when setuptools finds an importable package is listed in package_data rather than in packages. ¹ pypa/setuptools#3308 https://setuptools.pypa.io/en/latest/history.html#v62-3-0
tmzullinger
added a commit
to tmzullinger/rpmlint
that referenced
this pull request
Mar 7, 2023
Since setuptools-62.3.0¹, a warning is issued when setuptools finds an importable package is listed in package_data rather than in packages. ¹ pypa/setuptools#3308 https://setuptools.pypa.io/en/latest/history.html#v62-3-0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
When discovering files in
build_py, warn (SetuptoolsDeprectationWarning) if files and directories that correspond to a sub-package are included as "data".This is the first step towards #3260 (we first need to issue a deprecation so packages relying on this behaviour can implement the required changes)
Pull Request Checklist
changelog.d/.(See documentation for details)