Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warnings about bundled dependencies incompatibilities. #3296

Merged
merged 5 commits into from
May 16, 2022
Merged

Add warnings about bundled dependencies incompatibilities. #3296

merged 5 commits into from
May 16, 2022

Conversation

abravalheri
Copy link
Contributor

@abravalheri abravalheri commented Apr 29, 2022 •
edited
Loading

Summary of changes

  • Add a warning about incompatible verions of importlib_metadata

Closes #3292, #3293

Pull Request Checklist

@abravalheri
Copy link
Contributor Author

I am also (ab)using this PR to add a note in the changelog about pathlib (related to #3294).

@abravalheri abravalheri changed the title Issue 3292 Add warnings about bundled dependencies incompatibilities. Apr 29, 2022
@abravalheri abravalheri linked an issue Apr 29, 2022 that may be closed by this pull request
[BUG] AttributeError: 'str' object has no attribute 'name' with setuptools 60.9.1+ #3293
Closed
edmorley
edmorley reviewed Apr 29, 2022
View reviewed changes
Copy link
Contributor

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! :-)

setuptools/_importlib.py Outdated
msg = (
"`importlib_metadata` version is incompatible with `setuptools`.\n"
"This problem is likely to be solved by installing an updated version of "
"`importlib_metadata`."
Copy link
Contributor

@edmorley edmorley Apr 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the canonical package name is importlib-metadata, since that's what's on PyPI:
https://pypi.org/project/importlib-metadata/

Since end users will be needing to look for the requirement, rather than using the import - would it be best if the warning message used importlib-metadata instead of importlib_metadata?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the review @edmorley.

I agree with you about importlib-metadata.

@abravalheri abravalheri mentioned this pull request Apr 29, 2022
Closed
@abravalheri abravalheri marked this pull request as ready for review April 29, 2022 13:27
@abravalheri
Copy link
Contributor Author

@edmorley, I will leave the PR open just for a little while to see if the other maintainers of setuptools or other members of the community have any feedback about this change or would like to propose an alternative implementation.

@abravalheri abravalheri merged commit 1b8573e into pypa:main May 16, 2022
@abravalheri abravalheri deleted the issue-3292 branch May 16, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmorley edmorley edmorley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@abravalheri @edmorley