-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setuptools fails to install wheel files with duplicate entries in .data on Windows #1362
Comments
Thanks @wiggin15. Sounds like this is indeed a bug. I imagine the hard part of solving this is going to be writing a test for it (as is so often the case). |
I still don't think this should not be supported: we should detect it and throw an error. |
@benoit-pierre I think I may have misunderstood the issue, I thought that they were files that start in different folders but have the same name, pass through some intermediate stage where they are in the same folder, and then are distributed out to new locations where they have different names. If this is trying to install two different files in the same location, then I think it rightly should be raising an error. |
@pganssle I started discussion about this in pypa/packaging-problems#152 but no action has been taken yet. If we think this case should raise an error then this should be the behavior in "pip" and "wheel" too, but in order to open an issue for these projects we need a decision in the PyPA issue. |
easy_install fails to install, for example,
selenium
's wheel file:This is because selenium contains the following files in the wheel file:
setuptools tries to copy all the files from .data to the base directory (https://github.com/pypa/setuptools/blob/master/setuptools/wheel.py#L146) and
os.renames
(https://github.com/pypa/setuptools/blob/master/setuptools/wheel.py#L38) fails on Windows when the destination already exists.The text was updated successfully, but these errors were encountered: