Add fallback for find_files on git/hg archives
#752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i like the idea, it helps a bit with the pain |
RonnyPfannschmidt
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
@abravalheri this looks good, anything else to address, else i'll merge asap
|
It is all from my side :) Thank you very much Ronny. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation for the proposal in #751.
The main idea here is to list all the files if we successfully detect that
setuptools_scmis working with an archive.P.S.: This is an initial implementation as PoC. If there is interest for adding this feature I can iterate to improve the code's quality (any review/suggestion is appreciated).
If
setuptools-scmis not interested in supporting this kind of use case, please feel free to close the PR/issue.