Uninstall app fix #679
Merged
Uninstall app fix #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.mdSummary of changes
This should've been included with #672 (my bad). When looking at the metadata to determine the apps installed, we should check each
PackageInfoforinclude_appsto tell if there were apps ACTUALLY installed into the local binary directory. Injected packages usingpipx injectwithout the--include-appsswitch need to be handled here properly (they won't install their apps to the local bin dir).This really only affects uninstalls on Windows (without symlinks to determine parent venv) with injected packages. But it needs to be fixed nonetheless.
Test plan
Tested by running