-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use os.exec* for pipx run
app execution under POSIX.
#531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fbb4ad2.
gaborbernat
approved these changes
Oct 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.md
Summary of changes
This changes how a
pipx run
app is executed.For POSIX systems (AKA not Windows) it uses
os.execvpe()
to replace the current pipx process with the app in question. From that point on pipx is not acting as a parent process and is out of the picture.For Windows, this wasn't a reliable method, so for Windows
subprocess.run()
andsys.exit()
are used to approximateos.exec*
.Because now running an app never returns control to pipx, modifications to deleting a
.cache
venv when under--no-cache
operation had to be made. Previously this was done after running the app. Now, before running the app, a file namedpipx_expired_venv
is placed inside the venv as a signal to futurepipx run
invocations to delete this venv during_remove_all_expired_venvs()
.Testing was changed to accommodate the new behavior of exiting with an exit code instead of returning via
return
. The exit code is verified to be correct as needed.Closes #506
Incidental changes
I renamed
util.run()
toutil.run_verify()
to better describe what it is and why it is different fromrun_subprocess()
.Test plan
This should be an internal change to
pipx run
, and should only be cleaner with respect to certain cases, such as how signals are processed as described in #506 for example. Otherwisepipx run
should execute commands with no obvious differences than before.