-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1492: Add PIPX_GLOBAL_(HOME|BIN_DIR|MAN_DIR) documentation and list them in pipx environment
#1493
Fix #1492: Add PIPX_GLOBAL_(HOME|BIN_DIR|MAN_DIR) documentation and list them in pipx environment
#1493
Conversation
pipx environment
pipx environment
Could you also add a test for these variables, please? |
Is this minimal test expansion sufficient? |
I'd like to also test the paths, though not strictly necessary. |
Actually there are no paths to check here, because the variables are just added to the $ pipx environment --global
Environment variables (set by user):
PIPX_HOME=
PIPX_GLOBAL_HOME= # <-- added
PIPX_BIN_DIR=
PIPX_GLOBAL_BIN_DIR= # <-- added
PIPX_MAN_DIR=
PIPX_GLOBAL_MAN_DIR= # <-- added
PIPX_SHARED_LIBS=
PIPX_DEFAULT_PYTHON=
PIPX_FETCH_MISSING_PYTHON=
USE_EMOJI=
PIPX_HOME_ALLOW_SPACE=
Derived values (computed by pipx):
PIPX_HOME=/opt/pipx
PIPX_BIN_DIR=/usr/local/bin
PIPX_MAN_DIR=/usr/local/share/man
PIPX_SHARED_LIBS=/opt/pipx/shared
PIPX_LOCAL_VENVS=/opt/pipx/venvs
PIPX_LOG_DIR=/opt/pipx/logs
PIPX_TRASH_DIR=/opt/pipx/trash
PIPX_VENV_CACHEDIR=/opt/pipx/.cache
PIPX_STANDALONE_PYTHON_CACHEDIR=/opt/pipx/py
PIPX_DEFAULT_PYTHON=/usr/local/bin/python3.12
USE_EMOJI=true
PIPX_HOME_ALLOW_SPACE=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Also nice improvement on the docs themselves 👍
Yep, I thought about creating a separate test and populating these variables manually, to verify they take effect. |
I'm sorry, I think this is a slightly bigger change than what I'm in for right now. I hope it's okay if I leave it at that. |
Sure, no problem! |
for more information, see https://pre-commit.ci
LGTM, thanks! Please rebase or merge. |
Fixed #1492
changelog.d/
(if the patch affects the end users)Summary of changes
PIPX_GLOBAL_HOME
,PIPX_GLOBAL_BIN_DIR
andPIPX_GLOBAL_MAN_DIR
to output ofpipx environment
under theEnvironment variables (set by user)
section.PIPX_GLOBAL_*
vars inpipx --help
,pipx install --help
,pipx environment --help
andinstallation.md
.Test plan
Tested by running