-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quotes to title and fix tag name in release action #1437
Conversation
Fixed! |
Thanks! Don't we also need to specify the new dependency in the |
Looks like everthing should work now. |
Btw, I removed |
Ah, right. Uploaded a correctly generated one. I think we need to copy over the job to generate the zipapp then. |
For this time, it's done anyway. For the future, it should be necessary to generate the zipapp directly before uploading to the release – as you pointed out, retrieving it from the preceding tests run results in incorrect version information. Can that be done in this PR? |
Done in the latest commit. |
Co-authored-by: chrysle <96722107+chrysle@users.noreply.github.com>
f6c70eb
to
f92ae1c
Compare
No description provided.