Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.7 #1005

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Drop Python 3.7 #1005

merged 5 commits into from
Nov 15, 2023

Conversation

chrysle
Copy link
Contributor

@chrysle chrysle commented Jun 19, 2023

  • I have added an entry to docs/changelog.md

Summary of changes

Dropped support for Python 3.7 which is EOL on June 26, 2023.

Closes #1040

Test plan

Tested by running

# command(s) to exercise these changes

@chrysle chrysle changed the title Drop 3.7 Drop Python 3.7 Jun 19, 2023
@DimitriPapadopoulos
Copy link
Contributor

I would recommend changing this too:

if sys.version_info < (3, 6, 0):
sys.exit(
"Python 3.6 or later is required. "
"See https://github.com/pypa/pipx "
"for installation instructions."
)

@chrysle
Copy link
Contributor Author

chrysle commented Aug 13, 2023

I would recommend changing this too

Thanks, but I already did that.

@dukecat0
Copy link
Member

dukecat0 commented Oct 6, 2023

We may also need to remove this:

"importlib-metadata>=3.3.0; python_version < '3.8'",

@dukecat0
Copy link
Member

@chrysle I think it's time to merge this. Could you apply the above comment and resolve the conflict?

@chrysle
Copy link
Contributor Author

chrysle commented Nov 14, 2023

@chrysle I think it's time to merge this. Could you apply the above comment and resolve the conflict?

Sure, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Python 3.6 or later is required."
3 participants