Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back change vendoring of colorama. #5460

Merged
merged 3 commits into from
Nov 5, 2022
Merged

Roll back change vendoring of colorama. #5460

merged 3 commits into from
Nov 5, 2022

Conversation

matteius
Copy link
Member

@matteius matteius commented Nov 5, 2022

Quick fix to roll back change of vendoring of colorama to solve issue report.

The issue

Fixes #5458
Fixes #5459

@matteius matteius requested a review from oz123 November 5, 2022 00:29
@cclauss
Copy link
Contributor

cclauss commented Nov 5, 2022

Try https://pypi.org/project/rich instead?

@matteius
Copy link
Member Author

matteius commented Nov 5, 2022

@cclauss worth exploring, but pip also includes colorama and the breakage came about from trying to use that version rather than what we already had. Only had time to fix the release, but if you want to open a ticket to explore that, seems good.

@collectiontrip
Copy link

i had same problem you can upgrade your python 11 error will gone

@oz123
Copy link
Contributor

oz123 commented Nov 5, 2022

Regarding rich: I have a plan to remove the spinner class we use in favor of rich.
Rich itself uses colorama in Windows, and it isn't a replacement. However, once the Yaspin spinner from vistir is removed we definitely remove our version of colorama.

@cclauss
Copy link
Contributor

cclauss commented Nov 5, 2022

The final report used to say 3 of 25 dependencies were updated (or similar). Would it be possible to bring that back?

@oz123
Copy link
Contributor

oz123 commented Nov 5, 2022

Running which command?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants