Fix for inclusion of setuptools in the lock and install phase + other BAD_PACKAGES. #5231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After switching to use exclusively vendor'd pip for remaining commands, which includes install, two of the tests when run on python < 3.10 were failing in a weird loop where setuptools would get uninstalled and then be requested to install the newer version of setuptools and fail. I am not sure why this passed on python 3.10 or why its so problematic for versions less than 3.10.
The other thing this should fix is pipenv should no longer include BAD_PACKAGES in the Pipfile.lock -- these are packages that were already required be installed when installing
pipenvso it should not be necessary to include them in the lock. I had to manually delete setuptools from the pipenv Pipfile.lock to get the build to even run the tests for python versions < 3.10 in this PR: #5229