4642 fix pipenv lock --pre doesn't include prerelease dependencies #4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 18, 2021 14:12
uranusjr
requested changes
Mar 19, 2021
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
frostming
reviewed
Mar 19, 2021
frostming
approved these changes
Mar 19, 2021
uranusjr
approved these changes
Mar 19, 2021
|
Sorry to miss the updates here, will merge after the CI finishes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
#4642
pipenv lock --pre doesn't actually include prerelease dependencies
The fix
Used the already existing self.pre variable to append --pre to a built command that ultimately results in prerelease dependencies being included in the locking process. This seems to be consistent with conventions at least within that file, and doesn't require additional fields to be defined.
The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.