Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipenv --clear is not working #3354

Merged
merged 9 commits into from
Jun 6, 2019

Conversation

jxltom
Copy link
Contributor

@jxltom jxltom commented Dec 5, 2018

The issue

Closes #3353

The fix

  • pipenv --clear is supported by passing state.clear
  • The exposed several values from click is removed from cli's arugment since options such as clear, python, three may be used in subcommands. It is better to access these values via state.
  • Test is added

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@jxltom jxltom added the Category: Tests Relates to tests. label Dec 5, 2018
@jxltom jxltom removed the Category: Tests Relates to tests. label Dec 5, 2018
@jxltom jxltom force-pushed the fix-several-general-options branch from fa31ace to 0448f09 Compare December 5, 2018 02:50
@jxltom
Copy link
Contributor Author

jxltom commented Dec 5, 2018

Oh, found a bug in vistir, submitted a PR sarugaku/vistir#47 fixing that in upstream. This PR should pass after vistir is vendored in pipenv.

@jxltom jxltom force-pushed the fix-several-general-options branch from ef1b8c6 to d1875ba Compare April 1, 2019 11:43
@jxltom
Copy link
Contributor Author

jxltom commented Apr 2, 2019

@techalchemy I think this PR is ready to merge since vistir is updated from upstream.

@jxltom jxltom force-pushed the fix-several-general-options branch from d1875ba to 88e30d8 Compare May 7, 2019 02:48
@jxltom
Copy link
Contributor Author

jxltom commented May 7, 2019

Test for --three argument is added, test for --python has already existed in

@pytest.mark.cli
def test_pipenv_py(PipenvInstance):
with PipenvInstance() as p:
c = p.pipenv('--python python')
assert c.ok
.

@techalchemy techalchemy added Status: In Progress This item is in progress. Type: Maintenance 🚧 This issue pertains to maintenance of pipenv itself. labels May 20, 2019
@jxltom jxltom removed the Status: In Progress This item is in progress. label May 28, 2019
@techalchemy
Copy link
Member

for all the stuff that you're removing i'm assuming you have verified it still works?

@jxltom
Copy link
Contributor Author

jxltom commented May 29, 2019

for all the stuff that you're removing i'm assuming you have verified it still works?

yep :D

@techalchemy techalchemy merged commit 46a28a4 into pypa:master Jun 6, 2019
@jxltom jxltom deleted the fix-several-general-options branch June 7, 2019 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance 🚧 This issue pertains to maintenance of pipenv itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipenv --clear is not working
2 participants