-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pipenv --clear is not working #3354
Conversation
fa31ace
to
0448f09
Compare
Oh, found a bug in vistir, submitted a PR sarugaku/vistir#47 fixing that in upstream. This PR should pass after vistir is vendored in pipenv. |
ef1b8c6
to
d1875ba
Compare
@techalchemy I think this PR is ready to merge since vistir is updated from upstream. |
d1875ba
to
88e30d8
Compare
Test for pipenv/tests/integration/test_cli.py Lines 33 to 37 in cae8d76
|
for all the stuff that you're removing i'm assuming you have verified it still works? |
yep :D |
The issue
Closes #3353
The fix
pipenv --clear
is supported by passingstate.clear
cli
's arugment since options such asclear
,python
,three
may be used in subcommands. It is better to access these values viastate
.The checklist
news/
directory to describe this fix with the extension.bugfix
,.feature
,.behavior
,.doc
..vendor
. or.trivial
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.