Merge pull request #3319 from pypa/bugfix/3318

Abort pipenv when pip install fails
pypa · Nov 28, 2018 · f4c325c · f4c325c
2 parents 55057a8 + 6873145
commit f4c325c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/news/3318.bugfix.rst b/news/3318.bugfix.rst
@@ -0,0 +1 @@
+Abort pipenv before adding the non-exist package to Pipfile.
diff --git a/pipenv/core.py b/pipenv/core.py
@@ -1926,13 +1926,16 @@ def do_install(
                         extra_indexes=extra_index_url,
                         pypi_mirror=pypi_mirror,
                     )
+                    if not c.ok:
+                        raise RuntimeError(c.err)
                 except (ValueError, RuntimeError) as e:
                     sp.write_err(vistir.compat.fs_str(
                         "{0}: {1}".format(crayons.red("WARNING"), e),
                     ))
                     sp.fail(environments.PIPENV_SPINNER_FAIL_TEXT.format(
                         "Installation Failed",
                     ))
+                    sys.exit(1)
                 # Warn if --editable wasn't passed.
                 if pkg_requirement.is_vcs and not pkg_requirement.editable:
                     sp.write_err(

diff --git a/tests/integration/test_install_basic.py b/tests/integration/test_install_basic.py
@@ -431,3 +431,11 @@ def test_install_creates_pipfile(PipenvInstance):
         c = p.pipenv("install")
         assert c.return_code == 0
         assert os.path.isfile(p.pipfile_path)
+
+
+@pytest.mark.install
+def test_install_non_exist_dep(PipenvInstance, pypi):
+    with PipenvInstance(pypi=pypi, chdir=True) as p:
+        c = p.pipenv("install dateutil")
+        assert not c.ok
+        assert "dateutil" not in p.pipfile["packages"]
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Abort pipenv before adding the non-exist package to Pipfile.