Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch from 'retrying' to 'tenacity' #9599

Merged
merged 2 commits into from
Apr 3, 2021
Merged

switch from 'retrying' to 'tenacity' #9599

merged 2 commits into from
Apr 3, 2021

Conversation

cjc7373
Copy link
Contributor

@cjc7373 cjc7373 commented Feb 11, 2021

Closes #7530

Since we have dropped Python 2, there's no compatibility issue about this.

@cjc7373 cjc7373 force-pushed the switch-to-tenacity branch 2 times, most recently from 741f0ea to a6a3f70 Compare February 11, 2021 03:54
@cjc7373 cjc7373 marked this pull request as ready for review February 11, 2021 04:48
uranusjr
uranusjr reviewed Feb 11, 2021
View reviewed changes
src/pip/_vendor/tenacity.pyi
@@ -0,0 +1 @@
from tenacity import *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing trailing new line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing new line seems unnecessary.. (judging by other .pyi file)

@uranusjr
Copy link
Member

I think we should drop the tenacity.tests subpackage, but am not sure how with vendoring.

@cjc7373
Copy link
Contributor Author

cjc7373 commented Feb 11, 2021

Maybe upstream can fix this.. I've submitted a PR to them.

@pradyunsg
Copy link
Member

pradyunsg commented Feb 11, 2021 •
edited
Loading

Add it to the drop list, like we have for setuptools and all. The entry should be tenacity/tests.

In pyproject.toml, it'll be at tool.vendoring.<something>.drop.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 20, 2021
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 21, 2021
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Apr 3, 2021
@uranusjr uranusjr added this to the 21.1 milestone Apr 3, 2021
@pradyunsg pradyunsg added skip news Does not need a NEWS file entry (eg: trivial changes) and removed skip news Does not need a NEWS file entry (eg: trivial changes) labels Apr 3, 2021
@uranusjr uranusjr merged commit a118afe into pypa:main Apr 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jdufresne jdufresne jdufresne approved these changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
needs rebase or merge PR has conflicts with current master
Projects
None yet
Milestone
21.1
Development

Successfully merging this pull request may close these issues.

Switch from retrying to tenacity
6 participants
@cjc7373 @uranusjr @pradyunsg @BrownTruck @jdufresne @pypa-bot