Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused wheel_cache argument in freeze operation #9418

Merged
merged 2 commits into from
Jan 9, 2021

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jan 2, 2021

There is no reason why the freeze operation would use a WheelCache, and indeed this argument is unused. So I remove it.

@sbidoul sbidoul added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 2, 2021
@sbidoul sbidoul added this to the 21.0 milestone Jan 2, 2021
@pfmoore
Copy link
Member

pfmoore commented Jan 9, 2021

A quick note. Pip 21.0 is due for release in about 2 weeks (see #9282). This item is on the 21.0 milestone, so it either needs to be implemented and merged to master before then, or it will miss the release (and I'll move it to the 21.1 milestone).

@sbidoul
Copy link
Member Author

sbidoul commented Jan 9, 2021

@pfmoore this is ready to merge. BTW, I generally refrain to merge my own PRs. Do we have a policy about that (number of approvals, etc), or is it left to the appreciation and common sense of pip committers (which is fine with me too) ?

@sbidoul
Copy link
Member Author

sbidoul commented Jan 9, 2021

That said, I'm going ahead and merging this as it is quite trivial.

@sbidoul sbidoul merged commit e157cf5 into pypa:master Jan 9, 2021
@sbidoul sbidoul deleted the freeze-does-not-need-wheel-cache branch January 9, 2021 12:42
@pfmoore
Copy link
Member

pfmoore commented Jan 9, 2021

@sbidoul I tend to merge my own PRs once they have approvals from other core devs (or if they are sufficiently simple and I'm confident in my own work - not true that often!), and I tend not to merge other core devs PRs in case they want to do so themselves. It's not a policy, though, just how I prefer to work.

If you ever want someone to do a merge for you, even if just to cast a last extra pair of eyes over a PR, then feel free to ping me. When merging another core dev's code, I tend to just do "did it pass CI, are there any outstanding review comments" so it's not a big problem for me to push the button.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants