Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Matomo-based tracking in documentation #9146

Closed
wants to merge 4 commits into from
Closed

Add Matomo-based tracking in documentation #9146

wants to merge 4 commits into from

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Nov 19, 2020 •
edited
Loading

Toward #8517

As requested by @nlhkabu, for researching pip's documentation usage patterns.

@pradyunsg pradyunsg added type: docs Documentation related skip news Does not need a NEWS file entry (eg: trivial changes) labels Nov 19, 2020
@pradyunsg
Copy link
Member Author

/cc @pypa/pip-committers @brainwane @georgiamoon @ei8fdb for opinions.

I'm generally aiming to get this in sometime next week, after 20.3 is out.

@ei8fdb
Copy link
Contributor

ei8fdb commented Nov 19, 2020 •
edited
Loading

Moved comment to #8517.

@ei8fdb ei8fdb mentioned this pull request Nov 19, 2020
Open
@pfmoore
Copy link
Member

pfmoore commented Nov 19, 2020

I agree with @ei8fdb's comments that he moved to another issue. In particular, I think we should be transparent about collecting analytics here.

@pradyunsg
Copy link
Member Author

Yup yup.

As a general note, I think we should keep the "how should we do + communicate about this" discussion in the aforementioed issue, with the discussion in this PR being more "how do we implement what we want". :)

@pradyunsg
Tweak how noxfile handles virtualenv reuse
9304c90 
Signed-off-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
@pradyunsg
Add Matomo analytics JS and img tags
222f886 
Signed-off-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
@pradyunsg
Enable additional metrics on Matomo
2f0e204 
Signed-off-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
@pradyunsg
Fix MANIFEST for documentation stuff
1a41e52 
Signed-off-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
@pradyunsg pradyunsg force-pushed the matomo-tracking-in-documentation branch from 45c59c5 to 1a41e52 Compare November 19, 2020 18:39
@pradyunsg pradyunsg marked this pull request as draft November 27, 2020 21:45
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 20, 2021
@pradyunsg pradyunsg added needs rebase or merge PR has conflicts with current master and removed needs rebase or merge PR has conflicts with current master labels Feb 21, 2021
@pradyunsg
Copy link
Member Author

Closing since it seems unlikely we'd do this.

@pradyunsg pradyunsg closed this May 24, 2021
@pradyunsg pradyunsg deleted the matomo-tracking-in-documentation branch May 24, 2021 21:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
needs rebase or merge PR has conflicts with current master skip news Does not need a NEWS file entry (eg: trivial changes) type: docs Documentation related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pradyunsg @ei8fdb @pfmoore @BrownTruck