-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert defaulting to in-place builds for local directories #8221
Conversation
4a2d185
to
b81129d
Compare
TODO: rebase on master, for fixing CI. |
Technically, the revert seems ok. Thanks @pradyunsg! Still wondering if a good communication campaign about the change would not be better than a revert. Difficult choice. |
b81129d
to
6ed3234
Compare
I thought most of us were in agreement about this, that our best course of action is revert and re-evaluate. Plus there's been a "big blob of text" (#8165 (comment)) communicating to users that -- "we'll be reverting the "build in place" behavior change in a pip 20.1.1 release". I think the ship has sailed on "if" we revert this now -- we will -- but I don't think there's any reason we can't reintroduce this in pip 20.2 with a better (read: more thought out, less rushed because of @pradyunsg) rollout plan. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure how best to review something like this (I assume you used git revert
, and I certainly haven't checked line for line that it correctly reverted the commits it should have done) but in general this LGTM.
Toward #7555
Reopens (😞) #7549, #6276, #3500, #2195