Catches BadCommand in get_src_requirement() #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This catches the BadCommand that get raised by vcs modules when the VCS software is not installed or not in the PATH. In this case, we behave as if the .git, .svn or .hg folder hadn't been found at all (but with the correct warning).
|
Looks good. Flake8 picked up a couple of lines too long, but I'll fix those when we merge. |
|
@remram44 could you fix the pep8 issues |
|
@Ivoz sure thing. This should do...? |
pfmoore
added a commit
that referenced
this pull request
Jun 12, 2014
Catches BadCommand in get_src_requirement()
|
@remram44 Many thanks for the contribution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This catches the BadCommand that get raised by vcs modules when the VCS
software is not installed or not in the PATH. In this case, we behave as
if the .git, .svn or .hg folder hadn't been found at all (but with the
correct warning).
Fixes #930.