Patch out EXTERNALLY-MANAGED for self-check tests #13179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps redistributors test against their distro Python w/o spurious errors.
notatallshaw
approved these changes
Jan 26, 2025
|
I can confirm that applying this patch on top of the 25.0 release fixes the issue for me, thanks for the incredibly fast fix, that's awesome! 🎉 |
|
For those wondering about whether the self-check being disabled under an EXTERNALLY-MANAGED enviornment is still tested after this patch, yes it is, there's another unit test for this. I've decided to patch out EXTERNALLY-MANAGED for this test as it's testing the underlying implementation of the self-check, which should really be done regardless of the environment status. |
sbidoul
pushed a commit
to sbidoul/pip
that referenced
this pull request
Feb 9, 2025
This helps redistributors test against their distro Python w/o spurious errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps redistributors test against their distro Python w/o spurious errors.
Fixes #13176
If you have time @christian-heusel, I'd appreciate a test from you. You can download the source via
https://github.com/ichard26/pip/archive/test-hotfix.zip