Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vendored truststore to 0.10.0 #13041

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Conversation

sethmlarson
Copy link
Contributor

Closes #12901

@sbidoul
Copy link
Member

sbidoul commented Oct 25, 2024

Wondering why CI is complaining about the missing changelog entry...

@hugovk
Copy link
Contributor

hugovk commented Oct 25, 2024

https://github.com/pypa/pip/pull/13041/checks?check_run_id=32009990415 says:

No files matching re.compile('news/(?P<issue_number>[^\\./]+).(?P<fragment_type>removal|feature|bugfix|vendor|doc|process|trivial)(.\d+)?(.[^\\./]+)*.rst$') pattern added

And the PR is modifying an existing news/truststore.vendor.rst

Other PRs add a changelog entry like news/12771.feature.rst

The regex seems to match news/truststore.vendor.rst even if it doesn't really have an issue number:

https://regex101.com/r/uZgPX3/1

But maybe the problem is the file was modified, not added?

@sbidoul sbidoul added the skip news Does not need a NEWS file entry (eg: trivial changes) label Oct 25, 2024
@sbidoul
Copy link
Member

sbidoul commented Oct 25, 2024

But maybe the problem is the file was modified, not added?

Probably, yes. Thanks for the investigation.

@sbidoul sbidoul merged commit 3ca8921 into pypa:main Oct 26, 2024
33 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[24.2] installs fail on macOS 10.12 and older due to bundled truststore issue
3 participants