Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct keyring provider default #11942

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

Darsstar
Copy link
Contributor

Correct the default for --keyring-provider from disabled to auto. See #11939.

@Darsstar Darsstar force-pushed the correct-keyring-provider-default branch from a84bd95 to 9605b97 Compare April 10, 2023 09:13
@sbidoul sbidoul added this to the 23.1 milestone Apr 10, 2023
@sbidoul
Copy link
Member

sbidoul commented Apr 10, 2023

I understand this needs to go in 23.1, since the incorrect default was not released yet ?

I'm tentatively adding this to 23.1 but I'll let other maintainers review this as I'm not familiar with the keyring aspect of pip.

@sbidoul
Copy link
Member

sbidoul commented Apr 10, 2023

Also is it correct that this does not need a changelog because this was never released?

@pfmoore pfmoore added the skip news Does not need a NEWS file entry (eg: trivial changes) label Apr 10, 2023
@pfmoore
Copy link
Member

pfmoore commented Apr 10, 2023

So to be clear, #11698 (merged, and currently going to be released with 23.1) breaks backward compatibility by switching the default to disabled, but wrongly states otherwise in the docs. This PR fixes that to make the compatible behaviour the default, as was the original plan.

I'm good with getting this fixed. The fix looks fine to me, and the tests pass (although I don't fully follow them) so I'm going to hit merge on this. Thanks for sorting out a fix @Darsstar!

@pfmoore pfmoore merged commit 62e932a into pypa:main Apr 10, 2023
@Darsstar Darsstar deleted the correct-keyring-provider-default branch April 10, 2023 11:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants