Rework the functionality of PIP_CONFIG_FILE #11850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Mar 10, 2023
| @@ -29,11 +29,15 @@ pip has 4 "levels" of configuration files: | |||
| - `base` : per-base environment configuration file, shared across all virtualenvs with the same base. (available since pip 23.0) | |||
| - `site`: per-environment configuration file; i.e. per-virtualenv. | |||
|
|
|||
| Additionally, environment variables can be specified which will override any of the above. | |||
There was a problem hiding this comment.
Likely also need to mention command line arguments also override configs.
There was a problem hiding this comment.
We have this information already, in https://pip.pypa.io/en/stable/topics/configuration/#precedence-override-order
There was a problem hiding this comment.
I'm OK to move that section around, if people think that's too late in the file.
pradyunsg
requested changes
Mar 10, 2023
pradyunsg
approved these changes
Jul 2, 2023
7a1cdf1 to
64448f9
Compare
|
pre-commit.ci autofix |
2142220 to
8879dc4
Compare
|
Is there anything else I need to do for this? |
8879dc4 to
87878a8
Compare
87878a8 to
08c973b
Compare
pradyunsg
approved these changes
Oct 27, 2023
Also ensure iter_config_files behaves consistently with OVERRIDE_ORDER
for more information, see https://pre-commit.ci
207bef1 to
662246a
Compare
|
Thanks @dalebrydon, both for working on this and being patient & accomodating here! ^.^ |
fridex
pushed a commit
to fridex/pip
that referenced
this pull request
Nov 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11815. Properly document that
PIP_CONFIG_FILEwill override all other config files. Also make a minor modification and documentation change toiter_config_filesto have the order match the override order.I also documented the fact that setting
PIP_CONFIG_FILEprevents the user config file from being loaded. This feels like very weird behaviour to me, but has probably existed for too long to change at this point.