-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support keyring
when installed with pipx
#11588
Comments
I don't know what the original reasons were for not doing this, but I would strongly suggest reviewing the discussions on the original keyring implementation. There was a lot of debate, and it's unlikely that this option wasn't considered at all. Also, if we start down this route of using an external command line tool, are we likely to get requests for support for other tools to be added? The keyring support was the source of quite a few issues initially, and I don't think we want to deal with the quirks of multiple password managers... |
That's all very fair, however, the current state of the keyring integration makes its utility rather limited or at the very least frustrating. It isn't a great developer experience to have to run:
every time. For those of us using tools like
which strips keyring back out on the environment. This gets even worse when using plugins like I'd be willing to have a go reimplementing the current keyring integration if a |
keyring
when install with pipx
keyring
when installed with pipx
Going to have a read of #5952 |
@pfmoore It doesn't look to me like calling the command line interface was really considered in that original PR 🤔 |
Hmm, that's a bit of a shame. Maybe I misremembered how much discussion there was. I guess I'm not against this idea, although it's frustrating that we'll then end up with multiple keyring interfaces to support... |
Thanks for the contribution @judahrand! |
What's the problem this feature will solve?
Currently to use
keyring
it needs to be in the samevenv
aspip
. This seems like an unhelpful limitation askeyring
feels like a system-level tool which fits nicely withpipx
.Describe the solution you'd like
Rather than importing
keyring
pip
could call the command line version of the tool. This would work as long askeyring
is available inPATH
.Alternative Solutions
Open to suggestions
Additional context
None
Code of Conduct
The text was updated successfully, but these errors were encountered: