Add verbose flag to fetch_new() for bazaar, mercurial, SVN

pypa · Oct 10, 2021 · 3042def · 3042def
1 parent f312997
commit 3042def
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/src/pip/_internal/vcs/bazaar.py b/src/pip/_internal/vcs/bazaar.py
@@ -33,15 +33,16 @@ class Bazaar(VersionControl):
     def get_base_rev_args(rev: str) -> List[str]:
         return ["-r", rev]
 
-    def fetch_new(self, dest: str, url: HiddenText, rev_options: RevOptions) -> None:
+    def fetch_new(self, dest: str, url: HiddenText, rev_options: RevOptions, verbose: bool) -> None:
         rev_display = rev_options.to_display()
         logger.info(
             "Checking out %s%s to %s",
             url,
             rev_display,
             display_path(dest),
         )
-        cmd_args = make_command("branch", "-q", rev_options.to_args(), url, dest)
+        flags = ('--verbose',) if verbose else ('--quiet',)
+        cmd_args = make_command("branch", *flags, rev_options.to_args(), url, dest)
         self.run_command(cmd_args)
 
     def switch(self, dest: str, url: HiddenText, rev_options: RevOptions) -> None:

diff --git a/src/pip/_internal/vcs/mercurial.py b/src/pip/_internal/vcs/mercurial.py
@@ -33,17 +33,18 @@ class Mercurial(VersionControl):
     def get_base_rev_args(rev: str) -> List[str]:
         return [rev]
 
-    def fetch_new(self, dest: str, url: HiddenText, rev_options: RevOptions) -> None:
+    def fetch_new(self, dest: str, url: HiddenText, rev_options: RevOptions, verbose: bool) -> None:
         rev_display = rev_options.to_display()
         logger.info(
             "Cloning hg %s%s to %s",
             url,
             rev_display,
             display_path(dest),
         )
-        self.run_command(make_command("clone", "--noupdate", "-q", url, dest))
+        flags = ('--verbose', ) if verbose else ('--quiet',)
+        self.run_command(make_command("clone", "--noupdate", *flags, url, dest))
         self.run_command(
-            make_command("update", "-q", rev_options.to_args()),
+            make_command("update", *flags, rev_options.to_args()),
             cwd=dest,
         )
 

diff --git a/src/pip/_internal/vcs/subversion.py b/src/pip/_internal/vcs/subversion.py
@@ -277,17 +277,18 @@ def get_remote_call_options(self) -> CommandArgs:
 
         return []
 
-    def fetch_new(self, dest: str, url: HiddenText, rev_options: RevOptions) -> None:
+    def fetch_new(self, dest: str, url: HiddenText, rev_options: RevOptions, verbose: bool) -> None:
         rev_display = rev_options.to_display()
         logger.info(
             "Checking out %s%s to %s",
             url,
             rev_display,
             display_path(dest),
         )
+        flags = () if verbose else ('--quiet')
         cmd_args = make_command(
             "checkout",
-            "-q",
+            *flags,
             self.get_remote_call_options(),
             rev_options.to_args(),
             url,